Return-Path: Delivered-To: pape@smarden.org Received: (qmail 11647 invoked from network); 6 Jul 2008 14:44:37 -0000 Received: from ries.debian.org (ries.debian.org [128.148.34.103]) by a.mx.smarden.org ([212.42.242.37]) with ESMTP via TCP; 06 Jul 2008 14:44:37 -0000 Received: from joerg by ries.debian.org with local (Exim 4.63) (envelope-from ) id 1KFV5O-0002lL-PP; Sun, 06 Jul 2008 14:19:30 +0000 From: Joerg Jaspert To: Gerrit Pape X-DAK: dak process-new X-Katie: lisa $Revision: 1.31 $ Cc: Debian Installer X-Debian: DAK X-Debian-Package: netqmail Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: netqmail_1.06-1_powerpc.changes REJECTED Message-Id: Sender: Joerg Jaspert Date: Sun, 06 Jul 2008 14:19:30 +0000 Content-Length: 4492 Hi Maintainer, rejected, for various reasons (this mail applies to all of the various qmail and qmail related packages currently in NEW, namely netqmail, qmail-run, qmail-tools, dot-forward, fastforward). First - the packaging is nowhere near the standard Debian aspires to in the archive: Qmail is an MTA and as such should follow Debian Policy (for example Section 11.6). It's therefore not a very good start that an MTA package needs additional packages (qmail-run) installed to perform the minimal tasks required of mail-transport-agent, and yet another package (fastforward) to support /etc/aliases. Now, looking into the binary packages provided by netqmail there are a *few* points to list: qmail-uids-gids * Uses addgroup in preinst without a pre-depends * Uses useradd instead of adduser (policy 9.2.2) * Why install the uids/gids in preinst? * User interaction without using debconf (policy 3.9.1) in both preinst and postrm (ok, it's just giving info, but still) * Aborts in preinst if: - "Upgrading" from a pre 1.06 version (presumably unofficial) - UIDs / GIDs aren't what it expects (as the qmail binary then uses these UIDs *it* can't be installed without the UIDs being right, but why does qmail-uids-gids fail?) * Recommends manual use of userdel and groupdel rather than deluser / delgroup in postrm qmail * Installs /var/lib/qmail with alias, bin, boot, queue directories - Also: + users symlink to /etc/qmail/users/ + control symlink to /etc/qmail/ + doc symlink to /usr/share/doc/qmail/ - bin/ contains mostly symlinks back to /usr/bin and /usr/sbin but one binary is present (config-fast) - boot/ contains what looks like scripts (should probably be in /usr/lib/qmail with a symlink if necessary) - queue/ is basically the only part which any sane MTA would have in /var * Preinst fails if attempting an upgrade from < 1.06 (presumably unofficial) * Aborts in postinst if system doesn't have FQDN Looking at qmail-run there is also: * README recommends manually installing non FHS compliant symlinks: ln -s /var/lib/qmail /var/qmail ln -s /etc/service /service Not a policy bug, but certainly in bad taste... * C/R/Ps mail-transport-agent - Now, this does provide /usr/{sbin,lib}/sendmail - But as for /etc/aliases, /usr/sbin/newaliases is: #!/bin/sh cat >&2 <